CVSROOT: /home/cvs/fvwm
Module name: fvwm
Changes by: tadam 11/08/06 17:47:27
Modified files:
. : Tag: branch-2_6 ChangeLog
fvwm : Tag: branch-2_6 borders.c builtins.c events.c
ewmh_events.c frame.c fvwm.c menus.c
menustyle.c module_interface.c move_resize.c
placement.c session.c style.c virtual.c
libs : Tag: branch-2_6 FGettext.c Ficonv.c Graphics.c
PictureBase.c PictureImageLoader.c
PictureUtils.c fsm.c
modules : Tag: branch-2_6 ChangeLog
modules/FvwmAnimate: Tag: branch-2_6 FvwmAnimate.c
modules/FvwmButtons: Tag: branch-2_6 FvwmButtons.c draw.c
modules/FvwmCpp: Tag: branch-2_6 FvwmCpp.c
modules/FvwmForm: Tag: branch-2_6 FvwmForm.c ParseCommand.c
ReadXServer.c
modules/FvwmIconBox: Tag: branch-2_6 FvwmIconBox.c
modules/FvwmIconMan: Tag: branch-2_6 readconfig.c
modules/FvwmM4 : Tag: branch-2_6 FvwmM4.c
modules/FvwmPager: Tag: branch-2_6 FvwmPager.c x_pager.c
modules/FvwmProxy: Tag: branch-2_6 FvwmProxy.c
modules/FvwmRearrange: Tag: branch-2_6 FvwmRearrange.c
modules/FvwmScript: Tag: branch-2_6 FvwmScript.c Instructions.c
modules/FvwmScript/Widgets: Tag: branch-2_6 HScrollBar.c Menu.c
PopupMenu.c PushButton.c
RadioButton.c
modules/FvwmTaskBar: Tag: branch-2_6 FvwmTaskBar.c
modules/FvwmWharf: Tag: branch-2_6 FvwmWharf.c
modules/FvwmWinList: Tag: branch-2_6 ButtonArray.c FvwmWinList.c
Log message:
Fix compiler warnings for -Wset-but-not-used-variable (GCC 4.6+)
GCC 4.6 onwards now has, by default, a compiler warning check for those
variables which have been set/assigned a value, but never used for anything
else.
This is actually quite useful for us since it's flagged up certain code
paths which just haven't been exercised ever, leading to bit-rot. So that
code no longer exists.
The list of changes might seem large, but over all, the number of changes to
the code is actually quite small.
A note about this will be added to docs/DEVELOPERS and its newer eqivalent;
I am not proposing we consider turning off this warning check as part of our
standard build just yet -- depends how if/when/how many false-positives GCC
starts flagging up. For now though, it seems OK.
