2013/10/7 Dan Espen <[email protected]>: > Thomas Funk <[email protected]> writes: > >> Hi Dan, >> >> I have implemented two new options in fvwm-menu-desktop: >> --app-icon NAME set default application icon if no others found. >> Default is gnome-applications. >> --dir-icon NAME set default directory icon if no others found. >> Default is gnome-fs-directory. >> >> because gnome-applications' and 'gnome-fs-directory' not available in >> all icon themes. >> >> Therefore I have restructured fvwm-menu-desktop-config to reduce the >> window size to place the new options. >> >> Would you check my new placements please if it is understandable? I >> have removed some descriptions to hold the layout compactly. If all >> suits I will write a manpage for fvwm-menu-desktop-config. > > I see you've hard coded fonts for the FvwmForm: > > *${modname}: Font 7x13bold > *${modname}: InputFont 7x13bold > *${modname}: ButtonFont 7x13bold > > I don't think that's a good idea. > I'm using much bigger fonts due to my high resolution monitor. > Since we have a GUI for setting FvwmForm defaults, I don't think we > should be overriding those fonts in one of our tools.
Ok, then I remove these lines. > Everything else looks okay. > > "Usage" is misspelled on the first comment line in the .fpl file. Will check it. >> Attached is fvwm-menu-desktop-config.fpl and the new fvwm-menu-desktop >> for testing. > > Had me confused there, I didn't think you had commit access set up yet. I've sent you both for easy testing because of the two new options ;-) >> Another point is the thing with a xdg menu for Fvwm. Should we ship >> such menu with Fvwm generally? If so the question is what should we do: >> install it under /etc/xdg/menus/ or ship it as an example file and the >> user can decide by her/himself? >> >> I have created a common one with the needed directory files and it >> works fine on most systems. In some parts it could be changed but that >> is another point ;-) > > Not sure what you mean, I think you're talking about .desktop files with > Fvwm options in it, like start/restart Fvwm, etc? So that when someone > installs Fvwm they get menu options to start Fvwm. > > If so, definitely yes, it's something I wanted to do but never got to it. I don't ment fvwm.desktop placed in /usr/share/xsessions/. But that's no problem - we could use fvwm.desktop from the Fedora package. No, I mean a fvwm-applications.menu AND the needed directory files located in /usr/share/desktop-directories/. If you want it for testing I can send all as a tar.gz. - Thomas - > -- > Dan Espen >
