If you don't configure a setting for IconAndSelectButton,
modules/FvwmIconMan/x.c's X_init_manager() will wind up trying to
use contextDefaults[7] (down in load_default_context_[fore|back]()).
Unfortunately, per globals.c, the contextDefaults array only has six
entries. This can result in a coredump. I expect that this structure
was accidentally not updated when IconAndSelectButton was added recently
and NUM_CONTEXTS increased from 6 to 7.

 While debugging this, I noticed that the claimed order of things in
contextDefaults does not match the order of the Contexts enum. The
former has "plain" as entry 0, "title" as entry 4, and "default" as
entry 6 (currently), but in the enum DEFAULT is 0, PLAIN_CONTEXT is 4,
and ICON_CONTEXT is 6. I suspect that at this point the best fix is to
change the text strings for the labels to match the enum values, as
anyone using the actual defaults probably likes their current appearance
and won't appreciate that changing.

        - cks, who updated to CVS tip today for another reason

Reply via email to