On Sun, Sep 14, 2014 at 12:58:38PM +0100, Thomas Adam wrote: > On 14 September 2014 12:51, Dominik Vogt <[email protected]> wrote: > > What was the change good for? I vaguely remember that after a long > > discussion with other wm authors (Havoc?) the conclusion was that, > > given all the available documentation, that a window manager should > > react to new size hints only when the next ConfigureRequest > > arrives. Otherwise we could run into nasty race conditions. > > > > What is the situation this patch solves? > > It comes from this: > > commit 2b2f9a303832b6a23ce5c89752ad0fddc68ff417 > Author: tadam <tadam> > Date: Sat Mar 17 23:52:52 2012 +0000 > > Fix XSizeHints problem with FVWM not correctly allowing resizing of > windows when the hints are toggled with respect to FVWM processing > XA_WM_NORMAL_HINTS. Noticed by R. Parlett. > > I remember looking into this. Here's the original thread: > > https://www.mail-archive.com/[email protected]/msg02790.html > > ISTR I also had similar applications which were misbehaving without > this fix, but I have to say I've not seen any ill-effects from this.
Hrm, I understand, but I'm not comfortable with that. What if the new size hints make the current geometry of the window invalid, e.g. by setting a may size that is smaller than the window size, or by changing the resize unit? Then the next time the user grabbed the window's title to drag it aroud it would suddenly change its size. While the discussed use (forbidding resize) seems to be safe, this fix should be extended so that if the new hints would not allow the window's current geometry, they are ignored. I'll take a look. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
