On Mon, Oct 24, 2016 at 11:54:00PM +0100, Thomas Adam wrote:
> On Mon, Oct 24, 2016 at 10:29:30PM +0100, Dominik Vogt wrote:
> > ... but in a separate commit please.  Patching the NEWS file in
> > the same commit as the code change makes bug hunting and reverting
> > patches more difficult.
> 
> Maybe, but how often does that really happen?

It actually happens all the time when you want to reshuffle or
revert commits with NEWS entries.  The was worse with the
ChangeLog.  In CVS you wouldn't notice this often becaus you
couldn't rebase anything, but in Git its quite annyoing to my
experience.

> The problem with making NEWS
> file special somehow is going to cause problems with git-bisect because you'd
> be forever skipping over commits.

The worst that can happen is that you have twice as many commits,
i.e. one bisect step more that usual.  But actually NEWS commits
are quite rare.  Most of the changes don't make it into the NEWS
file.  So, yes, sometimes you'll have one more bisect step, but
that's maybe an extra three minutes or so.  I wouldn't worry about
that.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

Reply via email to