On Sat, Aug 06, 2016 at 01:09:23AM -0700, GitHub wrote: > Branch: refs/heads/master > Home: https://github.com/fvwmorg/fvwm > Commit: 0c5211e20940cd8dc811753c83118107d6964c8c > > https://github.com/fvwmorg/fvwm/commit/0c5211e20940cd8dc811753c83118107d6964c8c > Author: Thomas Adam <tho...@fvwm.org> > Date: 2016-08-06 (Sat, 06 Aug 2016) > > Changed paths: > M fvwm/events.c > M fvwm/icons.c > M fvwm/menus.c > > Log Message: > ----------- > Expose: don't flush accumulated events > > When dealing with Expose events, don't ever flush the accumulated ones; the > handling of the queue here is incorrect, and ultimately gets addressed during > other operations. > > This should help fix the problem of ParentRelative icon pixmaps from > corrupting other icons, etc. > > > Commit: f51d113bf456d23fedbad73145d9c4f05d097bb8 > > https://github.com/fvwmorg/fvwm/commit/f51d113bf456d23fedbad73145d9c4f05d097bb8 > Author: Thomas Adam <tho...@fvwm.org> > Date: 2016-08-06 (Sat, 06 Aug 2016) > > Changed paths: > M fvwm/events.c > M fvwm/icons.c > M fvwm/menus.c
I fear this commit is too disruptive. Aggregating Expose events is very important to deal with race conditions cause by applications doing crazy stuff. Is there some explanation of the problem that was fixed with this commit? I'd like to revisit it and see what needs to be done with the aggregation code to fix it without completely removing it. Probably it just needs to stop aggregating more often. This code is actually the result of many hours dealing with totally broken applications and trying to keek fvwm responsive even when flooded with all kinds of stupid events. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
