On 18 Jan 2005 17:12:52 +0200, Evgeny Stambulchik wrote:
>
> >>In 2.5.*, when a pixmap is used for window borders, the right border is
> >>rendered separately (with shifted origin) using the pixmap, whereas in
> >>2.4.* the same pixmap was used, so for gradiented pixmaps it looks now
> >>(2.5) ugly.
> >
> >This is a feature. Now the window resizing and moving over other windows
> >do not flicker at all (smooth and fast decorations).
> >
> >I don't think it is possible to have both the old look and not the
> >constant border redrawing on interactive Resize. Yes, it is sad, but
> >flickering is more annoying, I don't even want to recall how ugly it was.
> >
> >So although I would definitelly like to have the way to define border
> >images nicely in the future, I think this may be done after 2.6.x.
>
> Here is a patch that corrects the bug. I don't see why it would cause
> any flickering. Works here since 2.5.8 upto 2.5.12:
>
> --- borders.c.orig 2003-08-08 20:19:18.000000000 +0300
> +++ borders.c 2004-06-06 19:16:50.000000000 +0300
> @@ -1549,7 +1549,17 @@
> relative_g.y = part_g.y;
> border_get_border_background(
> &bg, cd, &part_g, &relative_g, &free_bg_pixmap, w);
> - bg.pixmap.g.x = 0;
> + switch (part)
> + {
> + case PART_BORDER_E:
> + case PART_BORDER_NE:
> + case PART_BORDER_SE:
> + bg.pixmap.g.x = fw->frame_g.width;
> + break;
> + default:
> + bg.pixmap.g.x = 0;
> + break;
> + }
> bg.pixmap.g.y = 0;
> /* set the geometry for drawing the Tiled pixmap; maybe add the
> relief
> * as offset? */
>
>
> Comments?
I don't think this patch improves anything, borders look differently bad.
See 2 screenshots (a bit ugly), before and after applying your patch:
http://fvwm-themes.sourceforge.net/tmp/FvwmConsole-BorderStyle-TiledPixmap-orig.png
http://fvwm-themes.sourceforge.net/tmp/FvwmConsole-BorderStyle-TiledPixmap-patch.png
Regards,
Mikhael.
