On Mon, Sep 24, 2001 at 10:59:38AM +0200, Dominik Vogt wrote: > On Fri, Sep 21, 2001 at 01:46:28PM +0200, Olivier Chapuis wrote: > > On Thu, Aug 16, 2001 at 10:40:46AM +0200, Dominik Vogt wrote: > > > On Wed, Aug 15, 2001 at 08:06:42AM +0200, Olivier Chapuis wrote: > > > > I get a FvwmButtons core dump when I change colorsets and the buttons > > > > contains swallowed shaped app. > > > > > > > > ....... > > > > > > > Thiss core dump isn't very helpful. Obviously an X error occured > > > that was not handled and then the routine that should generate the > > > core dump crashed (probably by accessing an array index of > > > (unsigned char)-1 ). > > > > > > T'll submit a fix for the crash in XError.c. Please try to make > > > that happen again then. Also, I tried to reproduce this, but > > > could not. If the problem does not become obvious with a proper > > > core dump, can you please provide more information on the bug? > > > > The fix is obvious: I've added BadPixmap as an "acceptable errors" > > in myErrorHandler ... > > I don't think the fix is obvious. The PrintXError... routine was > called with nonsense parameters and crashed. Simply not calling > it does not fix the underlying problem. >
I say it is obvious because I just have to add one line and this line can be found in some modules: [EMAIL PROTECTED] modules]$ grep -r "BadPixmap" * |grep "^Fvwm" FvwmButtons/FvwmButtons.c: || (event->error_code == BadPixmap)) FvwmIconBox/FvwmIconBox.c: if (event->error_code == BadPixmap) FvwmIconMan/x.c: case BadPixmap: FvwmIconMan/x.c~: case BadPixmap: FvwmScript/FvwmScript.c: if((event->error_code == BadDrawable) || (event->error_code == BadPixmap) || FvwmScript/FvwmScript.c~: if((event->error_code == BadDrawable) || (event->error_code == BadPixmap) || FvwmTaskBar/FvwmTaskBar.c: if (event->error_code == BadPixmap) FvwmWinList/FvwmWinList.c: if (event->error_code == BadPixmap) however one may found a better fix (I've gotten the same core and ErrorHandler message after your handler fix). Maybe the swallowed app which cause the problem (a "Window Maker" applet) do something irregular or nonstandard. Olivier -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
