On Wed, Sep 25, 2002 at 07:45:04PM +0000, Mikhael Goikhman wrote:
> On 25 Sep 2002 19:35:10 +0200, Olivier Chapuis wrote:
> > 
> > On Wed, Sep 25, 2002 at 01:49:19PM +0000, Mikhael Goikhman wrote:
> > > On 24 Sep 2002 12:22:26 +0200, Olivier Chapuis wrote:
> > > > 
> > > > On Mon, Sep 23, 2002 at 09:19:30AM +0000, Mikhael Goikhman wrote:
> > > > > On 23 Sep 2002 02:40:13 -0500, FVWM CVS wrote:
> > > > > > 
> > > > > > Log message:
> > > > > > * Clip text and icon drawing for the fvwm icons
> > > > > 
> > > > > Icons are practically do not flicker now when should be partially 
> > > > > redrawn.
> > > > > But png icons still flicker *a lot* by merelly focusing/unfocussing 
> > > > > them.
> > > > 
> > > > Is it ok now?
> > > 
> > > It seems that enter/leave now does not flicker (or flickers less).
> > > But focusing/unfocussing does flicker, you may open several png icons.
> > 
> > Yes, I cannot do a lot here (without horible tests). The icon pixmap
> > is redraw when at focusing/unfocussing as drawing depends on the
> > HilightColors/Colors.
> > So here the icon does not flicker it is redrawn o:)
> > Try, Colorset 1 IconAlpha 40 (ft).
> 
> I didn't know this line affects both Icons and pager's mini icons, nice.
>

As icons and Pager mini-windows use Colorset 1 in fvwm-themes.
 
> We really need a separate optional IconColorset (HilightIconColorset?),
> since so many users asked for it, I think you prepared everything for it.
>

I think we need a lot of new icon styles:

IconTitleColorset
HilightIconTitleColorset
IconBackgroundStyle [Colorset cset] [Frame x] [Padding x y]

and maybe a HilightIconBackgroundStyle.

> Returning to our flickering. It is annoying. Can the drawing be done
> somehow behind the scene, so that the final image (that is the same image)
> would not cause flickering?
> 

I do not think this is possible. With an icon pix with an alpha
channel, we must set the icon bg to the ParentalRelative pixmap. Then
when we draw we should first clear the icon bg, with the icon at the
good screen position so that the icon bg is "root" transparent. Then
we can draw the icon and the alpha channel is well composed with the
root bg.  The flickering you can see is caused by the icon bg
clearing.

The only way I see to remove this flickering at focus change, is to
compare certain entries of the hi_cs and cs colorsets and to draw only
if these entries are different *or* the icons has not been already
drawn. This leads to add a new entries in the FvwmWindow struct: "an
icon draw count". This is a bit complex for this flickering which is
caused by an icon state change (so this is maybe a feature o:) ????
 
> Ok, one more bug for you. Open xterm and FvwmConsole, define png icons.
> In FvwmConsole do "All (XTerm) Iconify on", the xterm icon is visible,
> the FvwmConsole icon is empty, but title is ok.
> 

Yes, a big miss print in the code. This will be fixed this day.

Olivier

--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]

Reply via email to