On 12 Nov 2002 21:22:21 -0500, Richard Lister wrote: > > Mikhael Goikhman <[EMAIL PROTECTED]> wrote on Sat, 9 Nov 2002 09:44:44 +0000: > > > > > > I will also reformat it to be more like FvwmPerl. > > > > > > Fine. > > > > At least here I guessed your answer correctly. :) > > I just downloaded the cvs snapshot and found you switched to 8-space > tab indentation, which was the worst thing I could have imagined :-) > Ah well, I suppose indentation styles are a bit of a religious war ...
This is not really correct. I don't use 8-spaces, I use one tab. Unlike our C code that requires TAB to be 8 spaces, our perl code is properly structured to allow any TAB size. Use 4 spaces for TAB if you like this, I use 3 or 8. Just please remember to write a properly structured code (no spaces for indentation, no tabs in the middle of line) not to break this TAB size freedom. I know, it is difficult with emacs... > > Ok, I did a lot of small changes, every change has its reason, take a look. > > I think you broke the drawminiicon option, but I don't know this idiom: > > $foo = 0 + !!$1; It only veryfies that $foo ends up to be a number (you compare this with numbers later, right?). But I forgot this is not a boolean (may be "2" as well). I will fix this. > Otherwise, I like all the changes you made. > > > The module still misses some configurability like sorting, automatical > > grouping, submenus, configurable format, class/resource/name resolution). > > But it is a good start to test future trackers. > > I've added title/icon/class/resource matching with a syntax like: > > *FvwmWindowLister: Show resource = Galeon|Navigator|mozilla-bin > > You can get the new version at: > > http://cns.georgetown.edu/~ric/software/fvwm/FvwmWindowLister > > I even added emacs mode settings for your indentation style :-) I don't think these are the right settings, they insert 4 spaces. In fact, I think the only way to configure emacs to do anything useful is to disable auto-indentation and insert real tabs on tab press. Regards, Mikhael. -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
