On Sun, Nov 24, 2002 at 10:00:59PM -0800, [EMAIL PROTECTED] wrote:
> I just did a commit on a small core mod and some larger proxy changes.
>
> The code czars may want to take look at fvwm/conditional.c to make sure
> I didn't wreck the Direction command. I'm pretty sure the non-cycle
> code path is hardly even touched.
I'll look at the functionality later. But in the mean time some
rules of the road you should follow when you edit files in the
core that I maintain (conditionals.c):
* Please always add all the names of the functions you touched
in the ChangeLog.
* 8 spaces per tab
* no more than 79 characters per line
* please keep the formatting style of the existing code (e.g.
placement of spaces)
* give flags a meaningful name, beginning with a modal verb,
e.g. "do_forward" instead of "forward"
* When you use the constants True and False only use them with
variables of type Bool and never assume they have a specific.
value. The code below is problematic at best:
int ordered = (forward == (cross < best_cross));
Instead it should be
ordered = (!!do_forward == (cross < best_cross));
Overall I would prefer to move the new functionality into a
separate function.
Bye
Dominik ^_^ ^_^
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
