On 03 Mar 2004 19:44:54 +0100, Arne Georg Gleditsch wrote: > > * Mikhael Goikhman > > With my suggestion you don't need to modify FvwmWindow structure. > > > > The suggested WindowNameFormat may be either a global command or a style > > option, but not a window context command like yours. Then this format > > string would be stored either globally or in style structure. > > > > visible_name contains the final name after expansion just like now. > > Hm. Perhaps I've been unclear. I use this functionality to assign > every window a different title suffix, where the contents of this > suffix indicate which hotkey will bring focus to the window in > question. The hotkeys are assigned from a arbitrary range; at the > moment I'm using the letters A..Z, and Win-A will bring focus to the > window marked with the suffix [A]. This hotkey/enumerated id/suffix > _is_ a window context property, and I can't see how to make the final > visible_name contain this without storing it in the window context > somehow.
I think, this is pretty uncommon situation, to give unique name format to every window. And you will still need additional work to manage and assign unique latter identifiers. You use a separate module for this. I can see why you need a window operation here rather then style. Anyway, then you should go with a Style option and use WindowStyle for your purpose. I don't think that direct modification of window structure is justified here. For example, I may imagine myself using this window name format feature for some windows, but automatically. i.e. I need a Style option, not just a window operation. And the attitude generally is to move every window operation to styles. > (Of course, the window id <-> hotkey mapping exists in the internal > state of the module providing this functionality as well, but as far > as I'm aware you can't do module callouts in string expansions. If > you can, then that would be a way to do this without adding stuff to > the window context.) > > > There are other problems with your patch, [..] > > No doubt there are, and I'll be happy to have a go at ironing them out > if/once the overall approach is deemed acceptable. Regards, Mikhael. -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
