On 19 Jun 2004 13:08:49 +0300, Victor Ananjevsky wrote:
>
> There is a patch for add Gtk2 support for FvwmGtk module instead of GTk 1.x
>
> I adapt this patch - http://www.hpc.uh.edu/fvwm/archive/0209/msg00563.html
> for cvs version of fvwm, make some cleanups and add new widget StockButton.
Nice, but I hope you have read all replies in the mentioned thread too.
I would not remove the gtk version 1 support, and support both versions
instead. This is a bit harder, but will make existing systems happy.
Can you try to do this? Version 2 may be preferred if both are found.
If you can't do this, then maybe we need FvwmGtk2 module in addition to
FvwmGtk, with both built when available.
> if (argc >= 3 && strcasecmp (argv[2], "on") == 0)
> - {
> gtk_toggle_button_set_state (GTK_TOGGLE_BUTTON (item), TRUE);
> - }
> else
> - {
> gtk_toggle_button_set_state (GTK_TOGGLE_BUTTON (item), FALSE);
> - }
Please do not remove block brackets for consistency with the rest of
the fvwm code.
> -void parse_rc_file(int argc, char **argv)
> +void
> +parse_rc_file (int argc, char **argv)
> {
> - g_return_if_fail(argc >= 1);
> + g_return_if_fail (argc >= 1);
>
> - gtk_rc_parse(argv[0]);
> + gtk_rc_parse (argv[0]);
> }
Please stay with K&R style, with tabs, no spaces after the function name
and so on. At least do not undo this style that is the main in fvwm.
Thanks.
Regards,
Mikhael.
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]
