On 2/4/06, Dan Espen <[EMAIL PROTECTED]> wrote:
>
> I think you need to keep the asterisk at the front of the name.
> There are times when you need it there, and times when you don't.
> It's easier to put it there in the first place rather than trying
> to stick it back when you need it.

Yes, it is far more efficient that way. But the problem is that the
existing structure only stores the name, and not the asterisk. Of
course we could use the existing char* MyName, but that would defeat
the whole purpose of using the ModuleArgs struct.

I wonder if we need the asterisk in the first place. Wouldn't it be
easyer "new-code-wise" to use only the name for pattern matching? It
could be stripped off by fvwm or simply not used in the config files.

(since this is only experimental code we are allowed to forget
backward compatibility issues)

> Since I put the macros there and I like to use macros,
> I have to ask what you think is wrong with them.
> Personally, I find that the more compact the code is,
> the easier it is to read.

Sorry, it's just my personal liking. Macros are also ok, what I don't
like in macros is that the code appears to be standard C but it's not
(it has its own syntax..).

And if it worked perfectly with the old code, it's puzling me with the new one:

Assuming we are to replace char* MyName with the struct, I currently
don't know what to do with one of the existing macros (the one that
uses the asterisk'ed name). Forgive my macros' ignorance, but I don't
know what to do to call CatString3() from within the macro.

Reply via email to