On 2/8/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > On Tue, Feb 07, 2006 at 09:01:34PM +0000, seventh guardian wrote: > > On 2/5/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > > > On Sat, Feb 04, 2006 at 02:27:20PM +0000, seventh guardian wrote: > > > > On 2/2/06, Dominik Vogt <[EMAIL PROTECTED]> wrote: > > > > > > > > > So, the work can be split into several smaller steps: > > > > > > > > > > 1. Make all the modules use ParseModuleArgs() and copy the fds > > > > > from the ModuleArgs struct to the arrays that are currently > > > > > used by the modules. > > > > > 2. Remove the fd arrays in the modules and use the fds in the > > > > > ModuleArgs instead. > > > > > 3. Make the service functions in Module.c use a (const ModuleArgs *) > > > > > instead of passing individual arguments and adapt the modules. > > > > > > > > > > > > > I'm working on it. I have a question though: modules usually use a > > > > global var to store the name lenght. Should it be stored in the > > > > ModuleArgs struct or should the modules call strlen() every time? > > > > > > I see no reson for not putting it in the ModuleArgs struct. > > > > > > > Done. Here's a patch incase you haven't already written one. > > Thanks, but can you please make a single patch out of this one and > your various module patches up to now? It's much less work for me > to apply and cross read. > > And please include ChangeLog entries for every file and function > you changed.
Sure. Here goes the patch against cvs. (I'll work on the cvs version from now on) Cheers! Renato Caldas
