On 08 Feb 2006 18:36:58 +0300, George Nephrite Potapov wrote:
>
> On Wed, Feb 08, 2006 at 04:01:15PM +0100, Dominik Vogt wrote:
> > > Here is the correct one. I'm very very sorry.
> >
> > Thats a nice patch with an important feature.
I agree.
Now, I have massive changes locally that make indentation of several
FvwmButtons files consistent with the main fvwm code. It will conflict
with this patch, but fixing this patch is much easier than my changes.
Can you please submit a patch after I commit the first pass on
FvwmButtons indentation changes?
I also have a request to you. Your patch looks like:
+void ButtonPressProcess (b, act)
+ button_info *b;
+ char **act;
+{
+ FlocaleNameString tmp;
+ int i,i2;
+
+ memset(&tmp, 0, sizeof(tmp));
+ if (b && !*act && b->flags.b_Panel)
+ {
+ ActiveButton = b;
I.e. in one small piece of code you use four variations for indentation:
* 2 spaces
* 4 spaces
* 8 spaces
* 1 tab
Please, correct your patch (after my commit) to consistently use 1 tab
only for indentation. Also, using other K&R conventions, like a space
after a comma or a space after non-functions (if, while) would be nice,
to be consistent with the main fvwm code. Thank you.
Regards,
Mikhael.
