On Sat, Jul 29, 2006 at 10:21:35PM +0100, Thomas Adam wrote: > On Sat, 29 Jul 2006 10:50:21 +0200 > Dominik Vogt <[EMAIL PROTECTED]> wrote: > > > On Fri, Jul 28, 2006 at 11:30:19AM +0100, Thomas Adam wrote: > > > Scott -- > > > > > > On Fri, 28 Jul 2006 15:27:22 +1000 Scott Smedley <[EMAIL PROTECTED]> > > > wrote: > > > > > > > Hi Thomas, > > > > > > > > > I noticed earlier that there is a discrepency in the FVWM manpage > > > > > (2.5.X series is the only one to be fixed) for the Wait command > > > > > description. The description says initially that the command waits > > > > > of "windowname". This is parly true -- the code in builtins.c > > > > > apparently also checks for the window's tile, class and resource > > > > > (just like how the style command works). > > > > > > > > > > I feel this needs to be reflected in its description > > > > > > > > ... > > > > > > > > > +.BI "Wait [" windowtitle | windowclass | windowresource "]" > > > > > > > > Personally, I think it would be prudent to stick with "windowname" here. > > > > A novice user might think it appropriate to specify, say, a window > > > > resource & then be surprised to learn that some other window with a > > > > matching _title_ was matched. > > > > > > > > > That's fine, and it makes sense of course. Quite often a window's name > > > (as it appears on the titlebar) is taken from WM_TITLE anyway. > > > > > > > > > > How about: > > > > > > > > Wait windowname > > > > This command is intended to be used in fvwm functions only. It > > > > causes execution of a function to pause until a new window > > > > matching windowname appears. A window can match windowname on either its > > > > title, class or resource. This is particularly useful in > > > > "InitFunction" if you are trying to start windows on specific > > > > desks or pages: > > > > > > > > It's still not perfect - any suggested improvements? > > > > Why not just use the same text as the style command: > > > > stylename can be a window's name, class, or resource string. It > > may contain the wildcards '*' and '?', which are matched in the > > usual Unix filename manner. > > > > Stylename should be replaced by something neutral, maybe just > > "window". > > That works for me, but other than agreeing with it, there's nothing more I > can do to correct it. :)
There is. You could make another patch and hope you'll eventually bother me enough to get commit privileges :-) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
