On Sat, Nov 20, 2021 at 08:51:46AM +0000, Thomas Adam wrote:
> This works,

Please revert this and apply the revert patch in my other message.

> but I am confused as to why it compiles fine for you:

It works on my local branch but not the one in Git because of the
reindentation commit.  Can we please not reindent patches that are
still under development?

I'll ditch the upstream branch for now and start a new one.

> diff --git a/fvwm/cmdparser_hooks.h b/fvwm/cmdparser_hooks.h
> index 42330246b..d8ebde017 100644
> --- a/fvwm/cmdparser_hooks.h
> +++ b/fvwm/cmdparser_hooks.h
> @@ -3,6 +3,9 @@
> +#include "cmdparser.h"
> +#include "functions.h"

1) Please no includes in header files.  It gets really messy and
   unmaintainable over time.

2) Including headers from headers potentiall _breaks_ the code.
   Several header files work differently if some macro is defined
   when they are included, for example libs/FEvents.h evaluates
   FEVENT_PRIVILEGED_ACCESS, but since it's included by many other
   headers, it's more or less random whether execcontext.c
   includes it before defining that or after.


Dominik ^_^  ^_^


Dominik Vogt

Reply via email to