"seventh guardian" <[EMAIL PROTECTED]> writes:
> On Fri, Feb 29, 2008 at 8:27 PM, Dan Espen <[EMAIL PROTECTED]> wrote:
> >
> > Dominik Vogt <[EMAIL PROTECTED]> writes:
> > > On Fri, Feb 29, 2008 at 02:40:26PM -0500, Dan Espen wrote:
> > > > Viktor Griph <[EMAIL PROTECTED]> writes:
> > > > > On Fri, 29 Feb 2008, Dan Espen wrote:
> > > > >
> > > > > >
> > > > > > I'm running a fairly recent CVS version of Fvwm.
> > > > > > I use root window icons, many of them shaped,
> > > > > > some of them titled.
> > > > > >
> > > > > > Recently, some of my icons started to show a 3d frame around them:
> > > > > >
> > > > > > http://mysite.verizon.net/despen/icons.gif
> > > > > >
> > > > > > The second from the top has a frame,
> > > > > > the third from the top doesn't.
> > > > > >
> > > > > > They both use png's with a transparent area around them.
> > > > > >
> > > > > > I think I like the effect.
> > > > > > What causes some of have the frame and other no frame?
> > > > >
> > > > > That would be your Style settings. The effect comes from the Style
> > > > > IconBackgroundRelief in conjunction with IconBackgrouondColorset.
> > > > >
> > > > > According to the manpage it is only drawn around icons with a backgr
> ound.
> > >
> > > > > I'm not sure why some icons are considered to have backgrounds, and
> some
> > > > > not.
>
> I believe this has to do with how png stores the transparency data.
> Some icons have an alpha channel, which is (unfortunately) currently
> ignored by default fvwm. On the other hand, "binary" transparent png's
> are correctly shaped.
>
> If you select an argb visual and activate a composite manager, then
> things change a bit. The otherwise well-behaved "binary transparent"
> png's display garbage at the transparent parts. But alpha channel'ed
> pngs start displaying correctly.
>
> (...)
> > > > Also this is something that just recently appeared.
> > >
> > > Can you pin it down to a specific version/CVS date and provide a
> > > config?
> >
> > I'll try but it might take me a while.
> > Pretty busy at work.
> >
> > Working from home is nice, but it makes it harder to stop.
>
> I'm not sure how you managed to get that kind of a "mixed symptoms",
> but we're waiting for your feedback on that ;)
I attempted to pin this down to a date but the symptom seemed
to come and go. I found it as far back as July but it didn't seem
consistent.
I just looked at the code for a few minutes and this
doesn't seem right:
add_window.c:
setup_icon_background_parameters(...
if (SHAS_ICON_BACKGROUND_RELIEF(&pstyle->flags))
{
fw->icon_background_relief =
SGET_ICON_BACKGROUND_RELIEF(*pstyle);
}
else
{
fw->icon_background_relief = ICON_RELIEF_WIDTH;
}
Changing ICON_RELIEF_WIDTH to zero makes the issue go away.
Why is it setting the relief width to the default of
2 pixels when the icon isn't supposed to have a relief?
--
Dan Espen E-mail: [EMAIL PROTECTED]
