On Sat, Jul 29, 2006 at 07:43:47PM +0100, Thomas Adam wrote: > On Sat, 29 Jul 2006 09:12:53 -0600 > "Scott Horowitz" <[EMAIL PROTECTED]> wrote: > > > I've noticed a strange issue in fvwm that does not occur in xfwm4 and > > metacity, for example. I wrote a quick pygtk app to demonstrate the > > problem: > > http://www.theskyiscrape.com/scott/test.py > > > > Essentially, ./test.py will open a gtk window in fullscreen - if you > > then press 'f' to toggle fullscreen mode, it successfully > > unfullscreens, but remains maximized as opposed to reverting to the > > default_size of 100x100 that I specified. However, if I then toggle > > the window back to fullscreen and unfullscreen again, it does revert > > to the non-maximized default_size, and continues to do this every > > additional time. I think it would be consistent (and the expected > > behavior) if the application was removed from maximized state after > > the first unfullscreen. > > I think you'll find this to be an issue with GTK as opposed to FVWM > mishandling anything.
I don't know. The reason is this code in ewmh_events.c:
if (...)
{
execute_function_override_window(NULL, NULL, "Maximize off", 0, fw);
}
else
{
/* the application started fullscreen */
SET_HAS_EWMH_INIT_FULLSCREEN_STATE(fw, EWMH_STATE_NO_HINT);
SET_EWMH_FULLSCREEN(fw, False);
if (DO_EWMH_USE_STACKING_HINTS(fw))
{
new_layer(fw, fw->ewmh_normal_layer);
}
apply_decor_change(fw);
/* the client should resize itself */
}
So, the window is not unmaximized when it leaves fullscreen state
for the first time if it had been created in fullscreen state. The
comment at the end suggests this is on purpose. THe EWMH spec
specifically states that the window manager has to resize the
window, so I think it is a bug.
I'll commit a fix.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
