On Fri, 26 Oct 2007, Viktor Griph wrote:
On Fri, 26 Oct 2007, Thomas Adam wrote:
On Fri, Oct 26, 2007 at 09:09:31PM +0200, Viktor Griph wrote:
Maybe the documentation is a bit unclear, and possible the name of the
option (which actualy was changed in 2.5.22) is a bit confusing. A better
name would probably be IncludeSkipList.
I don't think this is a good idea. There are a number of modules
(FvwmPager, FvwmTaskBar, etc.) which use "UseSkipList". You would have to
change those as well, breaking the commonality which has already been
established.
It's true that modules use this keyword, but they use it the reverse meaning,
i.e they obey the style, rather than use the option to disobey the style.
Having thw options with the same name thet do the opposite thing can't be
good. And it's not even consistent throughout the modules (I.e FvwmIconMan
uses "UseWinList" instead of "USeSkipList"))
Having thought some more about this I believe that the best thing to do
would to unify the meaning of UseSkipList to that it should obey the
WindowListSkip style, which is default for the WindowList command, and
change the option to have the items included to be !UseSkipList, but keep
UseListSkip as is (deprecated). This would break compatibility with the
change made in 2.5.23 only, and that change is very confusing the way it
is now.
Comments?
/Viktor
