Hi John,

Good spot! Indeed, all classes should require_once their dependencies.
Would you mind filing JIRA issue(s) against the components for which
this requirement is unfulfilled?

By the way, you might check the latest SVN. Some of the Yahoo component
classes I had fixed earlier this week, but I did miss one. :)

Thank you kindly for the report!

Best regards,
Darby

John Baldock wrote:
> Hi there,
> 
> I found one class that didn't require_once the class it extended by accident
> and thought I would check for others. I am still new here and I am unsure if
> it would be right to create lots of issues of the following so I thought I
> would post here instead. I checked the issue finder for each of the
> following and they do not seem to have been reported. 
> 
> These classes do not require_once the class they extend or implement:
> 
> Zend/Cache/Backend/ZendPlatform.php
> Zend/Gdata/Calendar.php
> Zend/Gdata/CodeSearch.php
> Zend/Gdata/Spreadsheets.php
> Zend/Locale/Math/PhpMath.php
> Zend/Memory/AccessController.php
> Zend/Search/Lucene/Analysis/Analyzer/Common/TextNum/CaseInsensitive.php
> Zend/Search/Lucene/Index/SegmentWriter/DocumentWriter.php
> Zend/Search/Lucene/Search/Similarity/Default.php
> Zend/Service/Delicious/Post.php
> Zend/Service/Yahoo/ImageResult.php
> Zend/Service/Yahoo/ImageResultSet.php
> Zend/Service/Yahoo/LocalResult.php
> Zend/Service/Yahoo/LocalResultSet.php
> Zend/Service/Yahoo/NewsResult.php
> Zend/Service/Yahoo/NewsResultSet.php
> Zend/Service/Yahoo/WebResult.php
> Zend/Service/Yahoo/WebResultSet.php
> Zend/Session/Namespace.php
> Zend/XmlRpc/Value/String.php
> 
> I put the above into a file along with the code needed to fix them, e.g.:
> 
> Zend/Cache/Backend/ZendPlatform.php
> /**
>  * Zend_Cache_Backend
>  */
> require_once 'Zend/Cache/Backend.php';
> 
> It's quite long so stuck it on my site:
> http://www.baldock-web-development.com/temp/missingRequires.txt
> 
> This is the code I used to find these (feel free to use/change/etc it):
> http://www.baldock-web-development.com/temp/code.txt
> 
> Hope this helps,
> John Baldock

Reply via email to