Hi Thomas, Looks pretty good! Congratulations!
I have reviewed component and it's generally OK It's well coded and conforms the original proposal. It doesn't have currency math done now, but I think it's for future. It has good tests coverage (77.80%). The documentation is excellent! I have one unit tests fault in my environment: ----------------------------------------- 2) testSimpleCreation(Zend_CurrencyTest) Failed asserting that <string:€ 1.000> is identical to <string:$ 1,000>. /home/cawa/ZendFramework/trunk/incubator/tests/Zend/CurrencyTest.php:78 /home/cawa/ZendFramework/trunk/incubator/tests/AllTests.php:41 /home/cawa/ZendFramework/trunk/incubator/tests/AllTests.php:55 ----------------------------------------- I think it may depend on current locale. The module is ready to be moved into core after resolving this testing issue. PS You may essentially increase unit tests code coverage by including Zend_Currency::getShortName() into tests. With best regards, Alexander Veremyev. > -----Original Message----- > From: Thomas Weidner [mailto:[EMAIL PROTECTED] > Sent: Friday, August 10, 2007 12:44 AM > To: [EMAIL PROTECTED] > Cc: [email protected] > Subject: [fw-general] Zend_Currency > > Dear ZF Community, > > the implementation of Zend Currency is finished and ready for > the core. You can find it in the incubator (minimum release SVN 6048). > > I would appreciate if some people would be willing to test the class. > We have a testbed and also two chapters of documentation for > this class. > > If all tests are OK I would like to have this new component > integrated within the release 1.1.0 > > Thanks to shreef for his initial implmentation. > > Greetings > Thomas > I18N Team Leader > >
