Probably you will have some other two-words patches in future, and you will already have CLA process passed :)
PS I'll fix it during weekend. It also has to be well-documented. With best regards, Alexander Veremyev. > -----Original Message----- > From: Carl Vondrick [mailto:[EMAIL PROTECTED] > Sent: Friday, August 24, 2007 10:13 PM > To: Alexander Veremyev > Cc: [email protected] > Subject: Re: [fw-general] Zend_Search_Lucene Storage Private > Properties > > On Friday, August 24, 2007, Alexander Veremyev wrote: > > I would like to suggest to modify source classes and make it > > configurable. It's exactly ZF-1429 JIRA issue > > (http://framework.zend.com/issues/browse/ZF-1429). > Yep, that's exactly the issue. For the time being, > overloading seems to be the best option though. > > > But you are right, there are no reasons to make these properties > > private instead of protected. Zend_Search_Lucene open() and > create() > > methods allows $directory parameter to be > > Zend_Search_Lucene_Storage_Directory_Filesystem object. So > it may be > > overloaded... > About that -- in my opinion, it should look for a > Zend_Search_Lucene_Storage_Directory object instead of a > _Filesystem object. > > > I'll take a look at this over weekend. Or you may offer a patch ;) > I would offer a patch, but it seems kind of silly for me to > go through the entire CLA process just to change two words. :-) > > Thanks for your responses, > > Carl >
