Thanks Darby, I'll enable them in the AllTests file and see what the future holds ;).
The main thing about any Crypt test is that the slowness is purely down to one extension and is pure math calculations - so there's nothing that can be cached or reused TestNG style. For the moment it should impose an extra 30s (max) to run time (that could be doubled if Zend_OpenId currently has any tests with Big Integer DiffieHellman calculations in the workflow) - if Zend_Crypt_Rsa is added at a future point (or if the DH tests are noted as being particularly slow) I'll look into adding constants to optionally skip over the worst offenders. On a plus side, the tests that could be skipped are very few in number - all the number crunching only effects one specific test at the moment. Thanks again, Paddy Pádraic Brady http://blog.astrumfutura.com http://www.patternsforphp.com OpenID Europe Foundation Member-Subscriber ----- Original Message ---- From: Darby Felton <[EMAIL PROTECTED]> To: Pádraic Brady <[EMAIL PROTECTED]> Cc: Zend Framework General <[email protected]> Sent: Friday, October 5, 2007 4:52:25 PM Subject: Re: [fw-general] incubator tests cleanup Hi Paddy, I'm unsure whether we have a well-defined policy on what is "too slow" to be run in the default configuration of the unit test suite. I tend to think that we should as many effective unit tests as possible, where they are not redundant, under the default configuration. Recently, Thomas was able to increase the speed of the Zend_Date tests by using a cache, if I recall correctly. There may also be other methods that can help speed up unit tests, depending on the situation. I hesitate to advise you to leave unit tests out of the default configuration because of slowness. I think it would be best to have the tests included first, and try to find ways to optimize them if necessary. That said, if later we find that we must leave certain tests out, this is easily accomplished by using constants in TestConfiguration.php. The web service and database components have some examples of how to skip tests fairly nicely. Best regards, Darby Pádraic Brady wrote: > Sort of related ;). > > I committed Zend_Crypt earlier today (thanks for getting svn back!). > > Some of these tests are really (and I mean really) slow because most > systems by default only have BCMath installed. Having DiffieHellman run > for 30 secs is not unusual. Is there any specific practice in place > addressing slow tests? Enough of these can become a nuisance if they are > padding test run time a lot. In a few weeks I expect to add RSA to the > mix (even more slowness). > > I'll enable the tests later in the Incubator Zend AllTests file - but if > there's any concern here let me know. > > Paddy > > Pádraic Brady > > http://blog.astrumfutura.com > http://www.patternsforphp.com > OpenID Europe Foundation Member-Subscriber <http://www.openideurope.eu/> > > > ----- Original Message ---- > From: Darby Felton <[EMAIL PROTECTED]> > To: Andries Seutens <[EMAIL PROTECTED]> > Cc: Zend Framework General <[email protected]>; [EMAIL PROTECTED] > Sent: Friday, October 5, 2007 4:11:45 PM > Subject: Re: [fw-general] incubator tests cleanup > > Hi Andries, > > Thanks for the report! I have committed some changes in revision 6589 > that solve the problems running the incubator AllTests suite for my > environment: > > http://framework.zend.com/fisheye/changelog/Zend_Framework/?cs=6589 > > Please test and let us know your mileage. > > Best regards, > Darby > > Andries Seutens wrote: >> Hi, >> >> I would like to bring this to your attention: >> >> The current tests folder in the incubator seems to be really messy. When >> running AllTests.php, it seems like the configuration file from the core >> tests is included as well, causing constants to already be defined, and >> producing tons of error messages. I have attached report.txt, which >> shows the current errors. >> >> There also seem to be some missing Zend_Db skiptests. >> >> Anyone cares to fix these issues? >> >> Best, >> >> >> ------------------------------------------------------------------------ >> >> Gecontroleerd op virussen door de JOJO Secure Gateway. > > > ------------------------------------------------------------------------ > Shape Yahoo! in your own image. Join our Network Research Panel today! > <http://us.rd.yahoo.com/evt=48517/*http://surveylink.yahoo.com/gmrs/yahoo_panel_invite.asp?a=7> > ____________________________________________________________________________________ Catch up on fall's hot new shows on Yahoo! TV. Watch previews, get listings, and more! http://tv.yahoo.com/collections/3658
