-- bfoust <[EMAIL PROTECTED]> wrote
(on Thursday, 22 May 2008, 12:49 AM -0700):
> Shouldn't line 1185 of Element.php be:
line 1188 in current trunk, btw. :-)
> if ($translator && method_exists($validator, 'setTranslator')) {
>
> ?
> It seems inefficient to call a method that just does some checks and
> then sets the already null _translator member to null again.
But, see, the validator's translator may not be null.
> It seems like a small issue, but just wanted to mention it as
> something that could be cleaned up in the next release.
The question isn't one of inefficiency so much as one of behavior:
if the element does not have a translator, should we disable a local
translator in the individual validators? The current code does exactly
that, but the question is if this is what developers expect or desire.
If not, please open an issue in the tracker requesting the change.
--
Matthew Weier O'Phinney
Software Architect | [EMAIL PROTECTED]
Zend - The PHP Company | http://www.zend.com/
