Robert, Hurry up and create a mailing list so people like me don't pollute the ZF mailing list with ZfWiki traffic! (that's my way of apologizing in advance for my off-topic post) ;-)
Interesting project, I wish you the best with it. I've poked through your svn repository and I have some suggestions for you. - config.ini should be in svn as config.dist.ini and config.ini should be added to svn:ignore - only the template configuration should be versioned, not a specific configuration file that could change from install to install - I'd suggest following the Zend Framework PHP Coding Standard. Specifically, use DocBlock style comments including the appropriate tags. - I'd suggest namespacing your models. For example, Pages could become Zfwiki_Db_Table_Pages or just Db_Table_Pages if you prefer. Also, why are some models under application/models and others in library? I would think you'd want one or the other unless you're truly bringing in whole other library. - Be sure to set svn:eol-style to native on PHP and other text-oriented files to avoid issues with multiple developers working on the project on different OS platforms. - Keep a separate SQL install script rather than having the SQL for a particular table commented in that table's class. Also, it looks like you have a binary SQLite database stored in svn - I'd suggest using SQL DDL to script the creation of these tables rather than storing them raw in svn. That's a lot easier to manage as changes are made over time. - I'd suggest enforcing GET or POST requests methods rather than just pulling the parameter regardless of request method. This is especially important with things like saveAction() - you definitely want that to only work on POST. - I'd suggest using Zend_Layout instead of rendering header and footer in your view scripts. Also, I like to keep my partial view scripts fully self-contained meaning that every HTML element needs to start and end in the same view script. Once you start having the start HTML element in one place and the closing element in another you're opening yourself up to some maintenance nightmares. - Why are .htacces, css, js, and images at the top-level? Shouldn't those be in a "public" or "htdocs" directory (or equivalent)? Hope these comments are helpful! Let me know if you want me to clarify any of these. On Thu, Jun 19, 2008 at 4:41 PM, Robert Castley <[EMAIL PROTECTED]> wrote: > Hi All, > > I am re-instated my interest in developing a Wiki using Zend Framework. > The fruits of the last twenty-four hours are now available. > > I am hosting the project over at GoogleCode: > http://code.google.com/p/zfwiki/ > > The Wiki uses the same wiki syntax (almost) as Confluence. The content is > called and displayed using AJAX via. ProtoType. > > This project is NOT stable and should NOT be used for production. It is > VERY experimental and is probably full of holes, bugs and XSS. > > Please download, have a play, feedback, suggest etc. even better if you > fancy joining in and helping out then drop me line. > > Over the next week or so I plan to add/integrate: > > - Zend_Auth > - Zend_Acl > - Zend_Search > - domPDF > > All the best, > > - Robert > > > ________________________________________________________________________ > This email has been scanned for all known viruses by the MessageLabs Email > Security Service and the Macro 4 plc internal virus protection system. > ________________________________________________________________________ > -- Bradley Holt [EMAIL PROTECTED]
