-- Sylvain Filteau <[email protected]> wrote (on Wednesday, 25 February 2009, 11:03 AM -0500): > I have questions about the patching/debugging/commit workflow of ZF, > specifically about the issue ZF-3379. I found this bug in the beginning of > february and I really want it to be fixed so I analyzed this and developped a > patch that pass the current unit tests but it's a "dirty" solution ;). > > What do I need to do with my patch other than post it in the issue tracker if > I > want it to be in the next version or at least just be reviewed ?
Best way is to include both the changes to the source code as well as a unit test within your patch; that way we can apply it in one go and immediately verify it without any extra work. (Often it takes a fair bit of time to derive a test case from the report, so having the test already written makes these trivial to apply and commit.) -- Matthew Weier O'Phinney Software Architect | [email protected] Zend Framework | http://framework.zend.com/
