Hi All, On Tue, Nov 30, 2010 at 11:20 AM, Brent Charbonneau <[email protected]> wrote:
> Hi Matthew, > > On Tue, Nov 30, 2010 at 10:42 AM, Matthew Weier O'Phinney < > [email protected]> wrote: > > Can you provide a unit test? >> >> I ask because the issue was marked once as resolved, but then >> re-opened... but without explaining *why* it's re-opened -- i.e., what >> expectactions are still not being met. If you can provide that, myself >> or somebody else will be able to review it better. >> > > I'll look into providing a Unit Test, but I believe the reason it was > reopened is the behavior as described by Marian, in the second comment: > > It seems to be not fixed. Subform without elements produces: >> <ul class="form-errors"><ul class="form-errors"></ul></ul> > > > When using the FormErrors decorator, if you add a subform to a form, it > always outputs the above empty markup, even when no errors exist (due to not > checking for an empty string returned from the subform decorator before > wrapping it with output markup). > Finally got around to writing it... I've added a diff for FormErrorsTest.php to the issue that adds a test case for the issue and the diff. Is this what you were looking for Matthew? http://framework.zend.com/issues/browse/ZF-9710 -Brent Brent Charbonneau » On The Web: http://blog.brentc.com » Over Email: bc [at] brentc.com » Twitter: http://www.twitter.com/bcharb -- On Tue, Nov 30, 2010 at 11:20 AM, Brent Charbonneau <[email protected]> wrote: > Hi Matthew, > > On Tue, Nov 30, 2010 at 10:42 AM, Matthew Weier O'Phinney < > [email protected]> wrote: > > Can you provide a unit test? >> >> I ask because the issue was marked once as resolved, but then >> re-opened... but without explaining *why* it's re-opened -- i.e., what >> expectactions are still not being met. If you can provide that, myself >> or somebody else will be able to review it better. >> > > I'll look into providing a Unit Test, but I believe the reason it was > reopened is the behavior as described by Marian, in the second comment: > > It seems to be not fixed. Subform without elements produces: >> <ul class="form-errors"><ul class="form-errors"></ul></ul> > > > When using the FormErrors decorator, if you add a subform to a form, it > always outputs the above empty markup, even when no errors exist (due to not > checking for an empty string returned from the subform decorator before > wrapping it with output markup). > > >> >> > Also - Christian Albrecht, the Zend_Form lead in JIRA, hasn't had any >> > activity in the system since July 20. Has he left the project? >> >> Not sure -- ask around on #zftalk.dev to see if anyone's seen him >> lately. >> > > /me looks around for his IRC client... :) > > -Brent > > Brent Charbonneau > » On The Web: http://blog.brentc.com > » Over Email: bc [at] brentc.com > » Twitter: http://www.twitter.com/bcharb > -- >
