On Thu, Mar 15, 2012 at 2:19 PM, Matthew Weier O'Phinney <[email protected]>wrote:
> Hey, all -- > > As part of the work for 1.12, I'm backporting the EventManager component > from ZF2 to ZF1. In working on it, I realized something: > SplPriorityQueue was not introduced until 5.3.0. > > Since ZF 1.X has a minimum version requirement of 5.2.4, This raises a > question: > > * Do I sniff for 5.3, and, if not present, raise an exception? > (Note: this would mean that we have an exception to the minimum > required PHP version for this particular component.) > +1 Can the exception say to upgrade their PHP version... and while they're at it upgrade to ZF2? > > * Or do I create a userland implementation of SplPriorityQueue in PHP > 5.2, and consume this if 5.3 is unavailable? (note: introduces new > code, and will also be less performant) > > Opinions? > I think allowing the older version to use new features isn't as important as the code for ZF2. Don't write something more to make it work. I'm all for the Exception rather than new code for ZF1. > > -- > Matthew Weier O'Phinney > Project Lead | [email protected] > Zend Framework | http://framework.zend.com/ > PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc >
