Patches item #1652005, was opened at 2007-02-05 09:50 Message generated for change (Comment added) made by wabz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1652005&group_id=235
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Richard Nelson (wabz) Assigned to: Nobody/Anonymous (nobody) Summary: msn file transfer details Initial Comment: I understand this doesn't make file transfer over msn any less silly, but this calls gaim_xfer_start so speed/other details can be calculated. Fixes bug 1651767 ---------------------------------------------------------------------- >Comment By: Richard Nelson (wabz) Date: 2007-02-09 08:26 Message: Logged In: YES user_id=698726 Originator: YES Okay. I didn't do that initially because there was a reason gaim_xfer_set_status was static inside ft.c - but I've made that reason clear in the doc, and now the msn prpl calls it. File Added: msnft.diff ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2007-02-09 03:33 Message: Logged In: YES user_id=20979 Originator: NO Hmm, currently only ft.c sets xfer->status to GAIM_XFER_STATUS_STARTED. And currently only ft.c emits the file-send-accept and file-recv-accept signals. I don't think it's a good idea to have the MSN prpl do that itself. It would be better to change the MSN prpl to somehow tell ft.c to set the status and emit the signal. ---------------------------------------------------------------------- Comment By: Richard Nelson (wabz) Date: 2007-02-08 20:58 Message: Logged In: YES user_id=698726 Originator: YES Updated patch sets start time/status, emits signal in the msn prpl. File Added: msnft.diff ---------------------------------------------------------------------- Comment By: Richard Nelson (wabz) Date: 2007-02-08 19:33 Message: Logged In: YES user_id=698726 Originator: YES Hmm, this patch only works for receiving, and I'm amazed at that (as gaim_input_add is given 0 as a fd). I'm not sure of the best way to do this... maybe the status/start time can be set at slplink.c:{495,556} and gaim_xfer_set_status could be public (so signal can be sent/without duplicating code)? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1652005&group_id=235 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Gaim-patches mailing list Gaim-patches@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gaim-patches