Patches item #1656984, was opened at 2007-02-10 16:25
Message generated for change (Comment added) made by rlaager
You can respond by visiting:

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Plugins
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: tombcore (tombcore)
Assigned to: Nobody/Anonymous (nobody)
Summary: little speed improvement in msn plugin

Initial Comment:
directconn write routine :
static size_t
msn_directconn_write(MsnDirectConn *directconn, const char *data, size_t len)
        char *Buffer;
        size_t buf_size;
        size_t ret;

        g_return_val_if_fail(directconn != NULL, 0);

        buf_size = len + 4;
        Buffer = g_malloc(buf_size);
        if (Buffer == NULL)
                return 0;

        /* Convert len int and paste it at the begining of buffer */
        *((guint32*)Buffer) = GUINT32_TO_LE(len);
        /* Then paste the data */
        memcpy(Buffer + sizeof(guint32), data, len);    
        /* And write it to the socket */
        ret = write(directconn->fd, Buffer, buf_size);

#ifdef DEBUG_DC
        char *str;
        str = g_strdup_printf("%s/msntest/w%.4d.bin", g_get_home_dir(), 

        FILE *tf = g_fopen(str, "w");
        fwrite(Buffer, 1, buf_size, tf);


        return ret;


>Comment By: Richard Laager (rlaager)
Date: 2007-02-10 17:56

Logged In: YES 
Originator: NO

What did you change? Can you submit this as a diff instead?


You can respond by visiting:

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
Gaim-patches mailing list

Reply via email to