Patches item #1668679, was opened at 2007-02-25 20:20
Message generated for change (Comment added) made by rlaager
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668679&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dossy Shiobara (dossy)
Assigned to: Nobody/Anonymous (nobody)
Summary: Make conversation name colorization colors Gaim preferences

Initial Comment:
While the Conversation Colors plugin allows you to control the colors of the 
conversation text, the colors of the "line prefix" (timestamp, name) are 
hardcoded into gtk/gtkconv.c (see the #defines for SEND_COLOR, RECV_COLOR, 
HIGHLIGHT_COLOR at the top).

The submitted patch moves these colors into the following gaim preferences:

/gaim/gtk/conversations/colors/send
/gaim/gtk/conversations/colors/recv
/gaim/gtk/conversations/colors/highlight

The default values match the colors currently specified in the #define's.


----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-02-27 20:00

Message:
Logged In: YES 
user_id=156487
Originator: NO

This definitely should be a gtkrc thing. Also, I'd like to see some good
solution to getting this sort of UI data from the UI to the core for
logging.

Having not thought about this much, I'd think that in chats, we should
send as whatever the IM send color is, otherwise we'll end up with varied
send colors depending on nick. Also, when we finally fix "group
conversations", we'd have to do that anyway, or your send color would
change based on how many other people (1 or >1) were in the conversation.

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-02-27 16:49

Message:
Logged In: YES 
user_id=28833
Originator: NO

I've been debating this mentally lately.  I wonder if in chats we should
send as whatever our nick would hash to. 

----------------------------------------------------------------------

Comment By: Sadrul Habib Chowdhury (sadrul)
Date: 2007-02-27 16:45

Message:
Logged In: YES 
user_id=1132702
Originator: NO

Do we want this only for IMs, or for chats too?

----------------------------------------------------------------------

Comment By: Luke Schierer (lschiere)
Date: 2007-02-27 16:41

Message:
Logged In: YES 
user_id=28833
Originator: NO

I dislike this approach.  I think they ought to be gtkrc things. 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668679&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gaim-patches

Reply via email to