Patches item #1670650, was opened at 2007-02-28 04:23
Message generated for change (Comment added) made by thekingant
You can respond by visiting:

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Eugene Crosser (crosser)
Assigned to: Nobody/Anonymous (nobody)
Summary: Make privacy settings for ICQ work

Initial Comment:
As of 2.0.0. beta6, privacy settings no longer change back themselves (see bug 
#1455192) but they still do not work, that is, you still receive messages from 
contacts that should be blocked.  At least for ICQ.  See bugs #1370335 and 
#1593579.  Maybe there is a similar problem with other protocols (bug #1071219) 
but I did not check that.

I found that, in my case for ICQ, protocol specific allow/deny check does not 
work, but as it *is* defined, "catchall" entry at libgaim/server.c line 434 
does not have effect.

I don't know if what I propose is a proper fix (because AIM specific functions 
do not work for ICQ), or merely a workaround, but just setting *_permit/*_deny 
entries in prpl_info to NULL seems to fix the problem with ICQ privacy settings.

Please could the developers look into my diff and either apply it or come up 
with a "correct" solution.


>Comment By: Mark Doliner (thekingant)
Date: 2007-02-28 11:54

Logged In: YES 
Originator: NO

I don't think this is a good idea.  Gaim's permit ad deny lists map to
icq's visible and invisible lists, and this change breaks that.  A correct
solution requires rewriting our privacy API, and no one has done that yet.


You can respond by visiting:

Take Surveys. Earn Cash. Influence the Future of IT
Join's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
Gaim-patches mailing list

Reply via email to