Patches item #1670473, was opened at 2007-02-27 21:42
Message generated for change (Comment added) made by thekingant
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1670473&group_id=235
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: PeterTang (petertang)
Assigned to: Nobody/Anonymous (nobody)
Summary: memory leak in msn_table
Initial Comment:
Every value in hashtable table->cmds is a hashtable ,too
But they are NOT released
So I think this to be added in function :
g_hash_table_foreach(table->cmds,cmds_destroy,NULL);
and the cmds_destroy is like this:
static void
cmds_destroy(gpointer key, gpointer value, gpointer user_data)
{
g_hash_table_destroy((GHashTable*)value);
}
----------------------------------------------------------------------
>Comment By: Mark Doliner (thekingant)
Date: 2007-03-01 03:33
Message:
Logged In: YES
user_id=20979
Originator: NO
Good catch. I just changed
table->cmds = g_hash_table_new_full(g_str_hash, g_str_equal, NULL, NULL);
to
table->cmds = g_hash_table_new_full(g_str_hash, g_str_equal, NULL,
(GDestroyNotify)g_hash_table_destroy);
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1670473&group_id=235
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gaim-patches
