Patches item #1668668, was opened at 2007-02-25 19:40
Message generated for change (Comment added) made by rlaager
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668668&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Casey Harkins (charkins)
Assigned to: Nobody/Anonymous (nobody)
Summary: tweak x11 docklet embedding

Initial Comment:
This patch has two changes:

First is to slightly change the re-creation behavior of the docklet. Sadrul 
pointed out on gaim-devel that the x11 docklet re-creates itself when it is 
destroyed and thought this might be causing problems with fluxbox. This patch 
now distinguishes between initial creation and re-creation. When re-creating, 
the docklet no longer registers itself as a visibility manager until it 
successfully embeds.

Second is to change the timeout behavior for embedding. Because the 
notification area API is asynchronous, gaim assumes the docklet gets embeded 
for a certain timeout period, allowing the buddy list to start hidden before 
the docklet has been embeded in the notification area. If the timeout occurs, 
it is removed as a visibility manager and the buddy list will become visible. 
This timeout has been set at 5 seconds. There have been a few reports that   
indicate this timeout period is not long enough when starting gaim from a saved 
session upon login. I have been hesitant to increase the timeout, as it has the 
potential of delaying the startup of gaim for the timeout period if the buddy 
list was hidden when gaim last closed  and there is not currently a 
notification area available. This patch makes the x11 docklet track whether it 
was successfully embedded and uses a longer timeout (15 seconds in this patch) 
only if it successfully embedded on the previous execution. Otherwise, 
 it uses the shorter 5 second timeout.

Hopefully this will resolve bug #1629586.

https://sourceforge.net/tracker/index.php?func=detail&aid=1629586&group_id=235&atid=100235


----------------------------------------------------------------------

>Comment By: Richard Laager (rlaager)
Date: 2007-03-02 08:37

Message:
Logged In: YES 
user_id=156487
Originator: NO

This sounds smart... so smart that I scrolled up to see who wrote the
patch. It all made sense then! I've been away from patches for a while, but
this sounds like a good one (from the description, haven't looked at the
code).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1668668&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gaim-patches

Reply via email to