Patches item #1652005, was opened at 2007-02-05 09:50
Message generated for change (Comment added) made by wabz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1652005&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Richard Nelson (wabz)
Assigned to: Nobody/Anonymous (nobody)
Summary: msn file transfer details

Initial Comment:
I understand this doesn't make file transfer over msn any less silly, but this 
calls gaim_xfer_start so speed/other details can be calculated. Fixes bug 
1651767

----------------------------------------------------------------------

>Comment By: Richard Nelson (wabz)
Date: 2007-03-05 14:43

Message:
Logged In: YES 
user_id=698726
Originator: YES

Here's an alternative. This one calls gaim_xfer_start and gaim_xfer_end
(at the moment msn's ft never calls _end, which means successful transfers
are not destroyed). It just calls _start with a fp of 0, and the input
watcher is then not added and MSN happily does its own thing. MSN just
copies the fp initialised from gaim_xfer_start and then sets it to NULL so
that there aren't two fclose()'s. Nicer?
File Added: msnft2.diff

----------------------------------------------------------------------

Comment By: Richard Nelson (wabz)
Date: 2007-02-09 15:59

Message:
Logged In: YES 
user_id=698726
Originator: YES

That's what I did initially (and it somehow worked for receiving).
However, it requires the fd for the file transfer socket (it then adds an
input watcher and reads/writes/updates xfer details), of which there isn't
for msn. The msn prpl does the work of opening/writing/updating xfer
information (bytes_(sent|received) etc) itself as it's all in-band. I guess
it could use gaim_xfer_start() if it was modified to ignore an fd of -1 or
something..?

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-02-09 09:04

Message:
Logged In: YES 
user_id=20979
Originator: NO

Is it not possible for the MSN prpl to just call gaim_xfer_start()?

----------------------------------------------------------------------

Comment By: Richard Nelson (wabz)
Date: 2007-02-09 08:26

Message:
Logged In: YES 
user_id=698726
Originator: YES

Okay. I didn't do that initially because there was a reason
gaim_xfer_set_status was static inside ft.c - but I've made that reason
clear in the doc, and now the msn prpl calls it.
File Added: msnft.diff

----------------------------------------------------------------------

Comment By: Mark Doliner (thekingant)
Date: 2007-02-09 03:33

Message:
Logged In: YES 
user_id=20979
Originator: NO

Hmm, currently only ft.c sets xfer->status to GAIM_XFER_STATUS_STARTED. 
And currently only ft.c emits the file-send-accept and file-recv-accept
signals.  I don't think it's a good idea to have the MSN prpl do that
itself.  It would be better to change the MSN prpl to somehow tell ft.c to
set the status and emit the signal.

----------------------------------------------------------------------

Comment By: Richard Nelson (wabz)
Date: 2007-02-08 20:58

Message:
Logged In: YES 
user_id=698726
Originator: YES

Updated patch sets start time/status, emits signal in the msn prpl.
File Added: msnft.diff

----------------------------------------------------------------------

Comment By: Richard Nelson (wabz)
Date: 2007-02-08 19:33

Message:
Logged In: YES 
user_id=698726
Originator: YES

Hmm, this patch only works for receiving, and I'm amazed at that (as
gaim_input_add is given 0 as a fd).

I'm not sure of the best way to do this... maybe the status/start time can
be set at slplink.c:{495,556} and gaim_xfer_set_status could be public (so
signal can be sent/without duplicating code)?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1652005&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gaim-patches

Reply via email to