Patches item #1686400, was opened at 2007-03-22 22:18
Message generated for change (Comment added) made by ecoffey
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1686400&group_id=235

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Plugins
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Eoin Coffey (ecoffey)
Assigned to: Nobody/Anonymous (nobody)
Summary: Mono: Fixed an infinite loop at exit

Initial Comment:
Since .NET plugins were not defining a info->id, gaim_plugin_unload() would get 
stuck in an infinite loop trying to pass gaim_plugins_find_by_id() a NULL value.

Fixed this by requiring .NET plugins to define a Id.

Might make the mono-loader autogen one for plugins that don't define one (seem 
easier to just mandate the Id).

Also talking with etan in #gaim, it seems that gaim_probe_plugin should fail if 
info->id is NULL or empty.

I'm assuming grim will pick this up.

----------------------------------------------------------------------

>Comment By: Eoin Coffey (ecoffey)
Date: 2007-03-23 00:57

Message:
Logged In: YES 
user_id=470733
Originator: YES

Alrighty.

The attached patch includes three things:

1.) Small tweaks to the loader to bring it up to speed with new mono
versions and API wrapper changes that grim had made. (was in original
patch, just forgot about it :-P)
2.) .NET Plugins are now required to define an Id as part of their info.
3.) Modified gaim_probe_plugin to check for existence of info->id and to
make sure it's not empty;  Prints an error, stores an error in the plugin
and sets plugin->unloadable = TRUE.
File Added: mono-loader-in-a-working-state-and-bug-fixes.patch

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-23 00:27

Message:
Logged In: YES 
user_id=156487
Originator: NO

Separate files or together isn't a big deal. I just don't want to see a
known related bug with a simple fix not get fixed. ;)

----------------------------------------------------------------------

Comment By: Eoin Coffey (ecoffey)
Date: 2007-03-23 00:05

Message:
Logged In: YES 
user_id=470733
Originator: YES

ok.

I thought I was being more polite by patching them separately :-D

I'll start now and have a new combined patch up in an hour or two.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-22 23:36

Message:
Logged In: YES 
user_id=156487
Originator: NO

The fix to gaim_probe_plugin would be nice, should be easy, and I'd like
to see it done at the same time. ;)

----------------------------------------------------------------------

Comment By: Eoin Coffey (ecoffey)
Date: 2007-03-22 22:46

Message:
Logged In: YES 
user_id=470733
Originator: YES

The first hunk in mono-helper.c was to bring the loader up to date with
later mono releases (since I haven't touched this in a while).

And no the patch only contains the id fix and leaves probe_plugin alone.

----------------------------------------------------------------------

Comment By: Richard Laager (rlaager)
Date: 2007-03-22 22:30

Message:
Logged In: YES 
user_id=156487
Originator: NO

I don't understand the changes in the first hunk for mono-helper.c.

Also, your patch doesn't correct the behavior of gaim_probe_plugin, does
it?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1686400&group_id=235

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Gaim-patches mailing list
Gaim-patches@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gaim-patches

Reply via email to