Patches item #1689182, was opened at 2007-03-27 10:03
Message generated for change (Comment added) made by thekingant
You can respond by visiting:

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Will Thompson (resiak--)
Assigned to: Nobody/Anonymous (nobody)
Summary: gtkblist: remove code duplication, and plug a leak

Initial Comment:
Over in gtkblist.c, the code to generate plugin action menus is the same for 
regular plugins and prpls, except that there is non-NULL context in the latter. 
 It was copy-pasted.  Now it is not.

Incidentally, the version in gaim_gtk_blist_update_accounts_menu was leaking 
the list every time: a pointer to the start was kept, presumably with the 
intention that the list be freed, but it never actually was.


>Comment By: Mark Doliner (thekingant)
Date: 2007-04-01 13:32

Logged In: YES 
Originator: NO

I love patches like this


You can respond by visiting:

Take Surveys. Earn Cash. Influence the Future of IT
Join's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
Gaim-patches mailing list

Reply via email to