Patches item #1575202, was opened at 2006-10-11 06:45
Message generated for change (Comment added) made by rlaager
You can respond by visiting:

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Richard Nelson (wabz)
Assigned to: Sean Egan (seanegan)
Summary: Consistent docklet statuses

Initial Comment:
This brings the docklet status list in line with the
status selector - when only accounts of one protocol
type are online, show that protocol's statuses.


>Comment By: Richard Laager (rlaager)
Date: 2007-04-18 08:46

Logged In: YES 
Originator: NO

wabz: You're a developer now. ;) If this makes sense, you should commit it
to the Pidgin tree.


Comment By: Richard Laager (rlaager)
Date: 2006-11-19 01:08

Logged In: YES 
Originator: NO

Sean, can you take a look at this please?


Comment By: Richard Nelson (wabz)
Date: 2006-10-19 07:31

Logged In: YES 

Even after the changes to the statusbox for b4, choosing a
per-protocol primitive status from the docklet didn't make
the statusbox reflect the change. This is because
gaim_account_set_status does not update a saved status, or
create a new one.

I considered making gaim_account_set_status do Something
Smart, but decided it's really impossible to find out what
whatever is calling it really wants - is it trying to set
all accounts to a primitive status? Does it want a new one?
I think whatever is calling it should be aware that it's not
going to change the default status, and the statusbox isn't
going to update.

So, I made the docklet do what the statusbox currently does,
which is to find or create an appropriate saved status, and
set that (and woah, the statusbox now updates correctly ;).
This involved moving a bunch of code around. I've tested it
with several protocol combinations, single protocol,
changing the status from <wherever>, it _appears_ to work
okay :)


You can respond by visiting:

This email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
Gaim-patches mailing list

Reply via email to