On Wed, Mar 20, 2013 at 1:55 PM, Peter Cock <p.j.a.c...@googlemail.com> wrote:
> On Wed, Mar 20, 2013 at 1:52 PM, Nicola Soranzo <sora...@crs4.it> wrote:
>> Il giorno mer, 20/03/2013 alle 12.41 +0000, Peter Cock ha scritto:
>>>
>>> The patch just removes the MetadataElement call - is that wise?
>>
>> Hi Peter,
>> my question instead is, what are they for? With 'name' they have no
>> meaning.
>>
>>> Looking at the code, I don't see a recent API change regarding
>>> the name:
>>>
>>> https://bitbucket.org/galaxy/galaxy-central/history-node/default/lib/galaxy/datatypes/metadata.py?at=default
>>>
>>> Is there perhaps a universe_wsgi.ini setting which might be involved,
>>> since I've not seen this error locally?
>>
>> $ cd lib/galaxy/datatypes/
>> $ grep 'MetadataElement(' *.py|grep -v name
>>
>> returns nothing, so the 'name' parameter is really mandatory.
>>
>> Best,
>> Nicola
>>
>
> Good question - I'd have to ask Edward what he thought this did,
> but you seem to be right that as the code stands this metadata
> element is rather pointless.
>
> (I'm still puzzled why we don't see the error here though).
>
> I'll apply your patch and test it locally...
>
> Peter

Nicola - It looks good here, uploaded to the ToolShed as v0.0.15
http://toolshed.g2.bx.psu.edu/view/devteam/blast_datatypes

Raj - Could you apply the update from the ToolShed and
confirm if that fixes the problem for you?

Edward - have you received my direct email off list?

Thanks,

Peter
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

  http://lists.bx.psu.edu/

Reply via email to