On Fri, May 10, 2013 at 8:11 PM, Björn Grüning
<bjoern.gruen...@pharmazie.uni-freiburg.de> wrote:
> Hi Dave,
> that was fast.
> Thanks a lot!
> Björn

Thanks Dave,

I see this also should fix handling of JAR files in download_by_url :)

Could I suggest an enhancement to abort on undefined action types,
rough patch below (untested)? This will help give a clear error if a new
command is used but the Galaxy host is too old to implement it (which
is exactly the situation we'd see right now on the main Tool Shed if
the new download_file action is used).



$ hg diff
diff -r 65a81aead95e
--- a/lib/tool_shed/galaxy_install/tool_dependencies/fabric_util.py     Sun
May 12 11:52:55 2013 -0400
+++ b/lib/tool_shed/galaxy_install/tool_dependencies/fabric_util.py     Mon
May 13 10:29:17 2013 +0100
@@ -152,6 +152,12 @@
                             url = action_dict[ 'url' ]
                             filename = url.split( '/' )[ -1 ]
                             common_util.url_download( current_dir,
filename, url )
+                        else:
+                            # This will happen if the
tool_dependencies.xml is using a very new action:
+                            tool_dependency.status =
+                            tool_dependency.error_message =
"Undefined action type %r" % action_type
+                            return

 def log_results( command, fabric_AttributeString, file_path ):

Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:

To search Galaxy mailing lists use the unified search at:

Reply via email to