I am with Peter that the best thing to do is probably to specify
"true" or "false". We just had a similar report from Bjoern though -
the thinking being that this was probably allowed in the past (using
the truevalue/falsevalue) but Galaxy lost that functionality -
https://trello.com/c/iGk3f1pE.

https://github.com/bgruening/galaxytools/commit/df4fdcb526df17094e03372a76763572f2095be7#commitcomment-11073612

-John

On Fri, May 8, 2015 at 10:16 AM, Peter Cock <p.j.a.c...@googlemail.com> wrote:
> On Fri, May 8, 2015 at 3:05 PM, Peter Briggs
> <peter.bri...@manchester.ac.uk> wrote:
>> Hello
>>
>> I'm currently writing tests for a tool and think I've found a situation 
>> where the behaviour of the boolean parameter type does not seem correct 
>> within the test environment.
>>
>> The tool defines the following boolean parameter:
>>
>>  <param name="spmr" type="boolean" truevalue="--SPMR" falsevalue="" 
>> checked="False"  ... />
>>
>> and accesses its value in the <command> tag using:
>>
>>  -B $spmr
>>
>> i.e. if the boolean is true then this should output "-B --SPMR", if not then 
>> it should output "-B  ".
>>
>> This appears to work as expected when the tool is installed and used 
>> interactively. But when running the tests the 'falsevalue' is always 
>> returned, even if the value is set to the 'truevalue' in the tests i.e.:
>>
>> <param name="spmr" value="--SPMR" />
>>
>> and
>>
>> <param name="spmr" value="" />
>>
>> both return "-B  ".
>
> I think you may need to set the value to true/false here, e.g.
>
> https://github.com/peterjc/pico_galaxy/blob/master/tools/samtools_bam2fq/samtools_bam2fq.xml
>
> (It would be clearer if the test framework insisted on this, but it
> may be allowing the truevalue or falsevalue to be used - at least when
> they don't start with a minus sign?)
>
> Peter
> ___________________________________________________________
> Please keep all replies on the list by using "reply all"
> in your mail client.  To manage your subscriptions to this
> and other Galaxy lists, please use the interface at:
>   https://lists.galaxyproject.org/
>
> To search Galaxy mailing lists use the unified search at:
>   http://galaxyproject.org/search/mailinglists/
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  https://lists.galaxyproject.org/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/

Reply via email to