Hey Peter, this was indeed reported and fixed in
https://github.com/galaxyproject/galaxy/commit/7294bd0af33bc974684c8ed8d21e97017660ca22,
which should already be available in the release_15.05 branch of the
repository if you update.

Sorry for the trouble, and even though it's resolved now, thanks for taking
the time to debug this and write such a detailed error report including a
patch!


-Dannon

On Wed, Jun 17, 2015 at 9:03 AM Peter Briggs <peter.bri...@manchester.ac.uk>
wrote:

> Hello
>
> I think a bug was introduced into galaxy-dist between the 15.03 and
> 15.05 releases, for the "Share history with user" function. The function
> works for 15.03 but fails in 15.05.
>
> To reproduce:
> 1. Click on the "cog" icon for a history and select "Share or publish"
> 2. Under "Share History with Individual Users" click "Share with a user"
> 3. Enter the email of another user on the system and click submit
>
> In 15.03 this returns to the sharing screen and indicates that the
> history has been shared with the specified user; in 15.05 this produces
> a stack trace (or "internal server error" in a production setting").
>
> The following patch appears to fix the problem:
>
> diff -r c3cef260df88 lib/galaxy/webapps/galaxy/controllers/history.py
> --- a/lib/galaxy/webapps/galaxy/controllers/history.py  Fri May 15
> 15:20:17 2015 -0400
> +++ b/lib/galaxy/webapps/galaxy/controllers/history.py  Wed Jun 17
> 12:51:41 2015 +0100
> @@ -899,7 +899,7 @@
>           for history_id in ids:
>               history_id = self.decode_id( history_id )
>               history = self.history_manager.get_owned( history_id,
> trans.user, current_history=trans.history )
> -            histories.append(  )
> +            histories.append( history )
>           return histories
>
>       def _get_users( self, trans, user, emails_or_ids ):
>
> also available via this gist:
>
> https://gist.github.com/pjbriggs/65c29a87e094d4d257f6
>
> Apologies if this has already been reported/fixed elsewhere, or if
> there's a better way to submit this fix (if so then please let me know)
>
> Best wishes
>
> Peter
>
> --
> Peter Briggs peter.bri...@manchester.ac.uk
> Bioinformatics Core Facility University of Manchester
> B.1083 Michael Smith Bldg Tel: (0161) 2751482
> ___________________________________________________________
> Please keep all replies on the list by using "reply all"
> in your mail client.  To manage your subscriptions to this
> and other Galaxy lists, please use the interface at:
>   https://lists.galaxyproject.org/
>
> To search Galaxy mailing lists use the unified search at:
>   http://galaxyproject.org/search/mailinglists/
___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  https://lists.galaxyproject.org/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/

Reply via email to