Thank :)!

Fabien

Le 23/03/2016 00:01, Martin Čech a écrit :
Thank you for all the help Peter!

Also this is already backported and fixed in 16.01

Sorry for causing this bug in the first place.
M.

On Tue, Mar 22, 2016, 18:29 Peter Cock <p.j.a.c...@googlemail.com <mailto:p.j.a.c...@googlemail.com>> wrote:

    Well done for solving this Fabien, with only a small hint from me.
    I'm glad to see your suggested fix has already been applied to
    the Galaxy repository so should be in the next stable release.

    Thank you!

    Peter

    (Also thank you Martin, Nicola, Dan, etc)


    On Tue, Mar 22, 2016 at 8:43 PM, Martin Čech <mar...@bx.psu.edu
    <mailto:mar...@bx.psu.edu>> wrote:
    > Thank you very much for solving this Fabien, The PR with your
    fix has been
    > created here: https://github.com/galaxyproject/galaxy/pull/1985
    >
    > Martin
    >
    >
    > On Mon, Mar 21, 2016 at 5:43 PM fmareuil <fmare...@pasteur.fr
    <mailto:fmare...@pasteur.fr>> wrote:
    >>
    >> Hi Peter,
    >>
    >> I worked on it today and I found  the reason of this bug. In
    the upload.py
    >> tool, the existence of dataset.space_to_tab is tested. In the
    old version of
    >> the data library, when the option was unchecked, the value
    space_to_tab was
    >> None and the test worked. But in the new version the value of
    space_to_tab
    >> is "False", it's a string and the test "if
    dataset.space_to_tab" returns
    >> True.
    >> It is possible to fix it with a little correction of the
    >> "/lib/galaxy/webapps/galaxy/api/lda_datasets.py".
    >> I join a patch with this email.
    >> I can propose a pull request if you want.
    >>
    >> Best,
    >>
    >> Fabien
    >>


___________________________________________________________
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  https://lists.galaxyproject.org/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/

Reply via email to