On Mon, Jul 25, 2005 at 06:52:17PM -0400, John McCutchan wrote: > Yo, > > I'm attaching a patch that fixes the reference counting bugs > http://bugzilla.gnome.org/show_bug.cgi?id=172365 , > http://bugzilla.gnome.org/show_bug.cgi?id=302236 , and countless distro > specific bug reports. > > The bug symptom was that the kernel backends would drop the refcount to > 0 and then stop watching a directory, while the subscription layer would > think that it was still watching the directory. > > The cause of the bug was a missing return statement when removing a > subscription that was on the new subscription list. Gamin would ask the > kernel to stop watching a directory when it had never asked it to watch > it in the first place (because it was still on the new queue). This > caused the kernel ref counting to screw up. This was also why that > assert was causing a crash for me.
okay, > The patch also includes some debug changes, and I factored out the get > pid name code. I'm away from my main development machine, so I won't be > able to commit this until Sunday. Feel free to commit before then. I'm not sure why some messages were removed and other were added, but this looks cosmetic. I'm a bit surprized by the memset for the stat buffer, I would expect the kernel to fill out the bits, but this should be safe. So yes, sure, commit ! Daniel -- Daniel Veillard | Red Hat Desktop team http://redhat.com/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ _______________________________________________ Gamin-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gamin-list
