This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Ganeti core".
The branch, master has been updated
via 0671095494b732e7602235461ff6844058c6422a (commit)
from cc05a2211f0eba1c042763e0fb4277490f269789 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0671095494b732e7602235461ff6844058c6422a
Author: Niklas Hambuechen <[email protected]>
Date: Fri Sep 26 16:21:25 2014 +0200
design-optables: Fix maintenance pause example
The example filter did not actually do what was written in its description.
For `reason` predicates, the spec says
"This predicate is true, if one of the entries of one of the opcodes
in this job satisfies the expression."
The existing
["reason", ["!", ["=~", "reason", "maintenance pink bunny"]]]
would therefore match on pretty much all jobs submitted, as even
jobs with `--reason="maintenance pink bunny"` have other reason trail
entries that are not "maintenance pink bunny", and one such entry
suffices to satisfy the expression. Consequenlty, the given example
would in practice pause all new jobs.
The correct way to do this is a filter chain:
prio 0 ["reason", ["=~", "reason", "maintenance pink bunny"]] PASS
prio 1 ["jobid", [">", "id", "watermark"]] PAUSE
Signed-off-by: Niklas Hambuechen <[email protected]>
Signed-off-by: Klaus Aehlig <[email protected]>
Reviewed-by: Klaus Aehlig <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
doc/design-optables.rst | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
hooks/post-receive
--
Ganeti core
--
---
You received this message because you are subscribed to the Google Groups
"ganeti-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
