This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Ganeti core".
The branch, master has been updated
via 234a9b71b8e6b82d0a50b88cd4a17483921109e3 (commit)
from b22cfa7efac5f31eb4da7e869069444b9907cb51 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 234a9b71b8e6b82d0a50b88cd4a17483921109e3
Author: Niklas Hambuechen <[email protected]>
Date: Wed Oct 8 16:15:59 2014 +0200
ReasonRateLimiting: Fix scheduling rate-limited jobs
The semantics change in the SlotMap simplification (commit 7a3aa19)
purposely made `hasSlotsFor`/`occupySlots` reject keys that were not
in the SlotMap, for example
[] `hasSlotsFor` [("key", 1)] == False
Unfortunately, I forgot to adjust the `initSlotMap` in `reasonRateLimit`:
While before it was allowed to start empty (`occupySlots` would create
the slots on the fly), commit 7a3aa19 should have changed it to start
with all keys present and set to all buckets unoccupied.
This led to all jobs with a `rate-limit:n:...` reason to be
rate-limited unconditionally (they were never run).
This commit fixes it by adjusting `initSlotMap` as described above.
Signed-off-by: Niklas Hambuechen <[email protected]>
Reviewed-by: Klaus Aehlig <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
src/Ganeti/JQScheduler/ReasonRateLimiting.hs | 25 ++++++++++---
test/hs/Test/Ganeti/JQScheduler.hs | 48 ++++++++++++++++++++++++++
2 files changed, 67 insertions(+), 6 deletions(-)
hooks/post-receive
--
Ganeti core
--
---
You received this message because you are subscribed to the Google Groups
"ganeti-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
