On Tue, Sep 9, 2008 at 8:48 AM, Iustin Pop <[EMAIL PROTECTED]> wrote: > On Mon, Sep 08, 2008 at 03:51:23PM +0100, Guido Trotter wrote: >> >> This new function checks whether an instance is running, before shutting >> down its disks. This is what the Exec() of LUDeactivateInstanceDisks >> did, so that is replaced by a call to this function. >> --- > > This naming is very misleading. I look at the code and I see > "StopInstanceDisks" and "ShutdownInstanceDisks", which does what? > > Please name one "UnsafeShutdownInstancedisks" and one (with the check) > "ShutdownInstanceDisks" so we can tell them apart... >
That was just to make it similar to the _StartInstanceDisks one... I can do that, but I'll have to change the callers of the previously existing one... Thanks, Guido
