On Thu, Apr 23, 2009 at 07:07:57PM +0200, Guido Trotter wrote: > On Thu, Apr 23, 2009 at 6:55 PM, Iustin Pop <[email protected]> wrote: > > > > When vg_name is not returned at all, we currently abort with an internal > > error. This is because we don't catch KeyError. > > > > This patch adds a custom message for this case, and also adds KeyError > > to the list of catched exceptions, just for safety. > > > > LGTM
thanks! > > On the other hand, we could also just remove this piece of code since > > it's not used at all the ["dfree"] value. > > Well, it checks that the VG is there, so... Yeah, but this is checked before too; so while right now it's extra (and gives 3 ERROR: ... lines for a missing VG), I'd still leave it in because in the future maybe we want to check for free disk space in case of N+1 (something which we don't do today). iustin
